search

lxqt / pcmanfm-qt

File manager and desktop icon manager (Qt port of PCManFM and libfm)
https://lxqt-project.org
GNU General Public License v2.0
426 stars 112 forks source link

Populate Bookmarks menu icons to match side pane #1956

Closed isf63 closed 1 month ago

isf63 commented 1 month ago

One-line change

Uses the same icons in the side pane for the Bookmarks menu.

tsujan commented 1 month ago

Sorry but, IMO, this ruins that sleek menu with an excess of duplicated icons. I've kept the menu intentionally as it is.

isf63 commented 1 month ago

Sorry but, IMO, this ruins that sleek menu with an excess of duplicated icons. I've kept the menu intentionally as it is.

It was inspired by Thunar, which is in quite a few ways similar to PCManFM-Qt.

It depends on the icon theme whether the icons are distracting or not. But I'll heed your judgement.

I also noticed that for "Places" in the side pane and the "Go" menu, only 2 of the 6 items share the same position. Also 'Applications' and 'Network' have common icons in the side pane, where with mate-icon-theme, those items under "Go" have no icons. Thoughts?

tsujan commented 1 month ago

I also noticed that for "Places" in the side pane and the "Go" menu,...

Having menu icons shared by other widgets isn't a problem. For example, the Go menu has 5 different Places icons that make it easy to find the relevant item. In contrast, multiple folder icons in the Bookmarks menu would have no real use — most users don't change the icons of their bookmarked folders.

IMHO, giving icons to every menu-item may defeat the purpose of having icons, which is finding items more quickly. The Plus icon in the Bookmarks menu is enough; no Edit icon is needed either.