search

lxqt / qps

Qt process viewer and manager
https://lxqt.github.io
GNU General Public License v2.0
74 stars 38 forks source link

Program doesn't show processes after closing it with the "exit on closing" option disabled #447

Closed glu8716 closed 8 months ago

glu8716 commented 1 year ago
Expected Behavior

I've disabled the "exit on closing" option in the Preferences. When I close the program it minimizes to the tray icons. When I open it again after some minutes or hours I'd expect to see the processes.

Current Behavior

I don't see the processes after the program has been closed for some minutes or hours (not sure about the timing).

Possible Solution
Steps to Reproduce (for bugs)
  1. Disable "exit on closing" in Preferences
  2. Close the program. It will minimize to the tray icons
  3. Open it again after some minutes/hours
  4. The programs doesn't show processes
Context
System Information
tsujan commented 10 months ago

@javier-fuentes, @Bluey26 Please test https://github.com/lxqt/qps/pull/454 to see if makes any difference regarding this issue. @javier-fuentes, your test could especially be of great help because you can easily reproduce the too-many-open-files situation.

As I'd expected, the reduction in opened file handles was small for me (~3%), but it may be large for you.

Bluey26 commented 10 months ago

Perfect. I pulled the new build https://github.com/lxqt/qps/tree/d3dbe988804aaf5e279faaf42f7bd2ea173f3352 , ran the usual commands and now i have the program running from a terminal tab, i will inform if i see something. I have not seen the error in a while, but I will let it a few hours running to see what happens.

lsof | awk '{ print $1 " " $2; }' | sort -rn | uniq -c | sort -rn | head -15

Running that command again does not show me the 'qps' process. In the other hand, when i expand the list, from 15 to 30, i see qps with this values:

1393 qps 336184

I guess that is a normal amount (1393) of files used. Command was run after 1 or 2 minutes of the new qps build running.

To add more, after reading the #251 , i also have a lot of 'Isolated Web Content' processes running, which belongs to firefox. I guess that could be a cause to qps 'losing' the amount of read files and going to blank.

UPDATE: After 3 hours, qps read files increased up to 1407, there was a 'heavy' using during the process, like updates and several firefox tabs opened. The program worked correctly during all that time, no blank process list.

tsujan commented 10 months ago

@Bluey26 Thanks! Yes, 1393 is normal; mine is 2480. I hope @javier-fuentes will test it too before the next release (which will come in a few days), as he can reproduce the worst situation easily. Also @glu8716.

tsujan commented 10 months ago

... during all that time, no blank process list.

That was good news. I keep the report open though.

I merged https://github.com/lxqt/qps/pull/454 for 2.8.0. Whether it really prevents this issue or not, it fixes a bug that was hidden for a very long time.

javier-fuentes commented 9 months ago

I'm on vaccation without my laptop and I won't be able to test it for seven days at least, but I've been reading last updates by @blue26, and the commits by @tsujan and I feel confident that my problems will be fixed also. Congratulations @tsujan and thank you for your nice work.

tsujan commented 9 months ago

I won't be able to test it for seven days at least

Take your time; there's no haste. V2.8.0 will be released with the patch today, but I won't close the report before you confirm the fix. This mysterious issue may have more than one cause.

glu8716 commented 9 months ago

I have been away from the thread for a few days. I'm testing the new version. So far so good. Will report back if the bug happens again.

glu8716 commented 9 months ago

Tested for 3 days and... wow! The bug seems to be gone. Many thanks! @tsujan I'll test more before jumping to conclusions but I think you have made it :)

tsujan commented 9 months ago

@glu8716 It was a team work. If it weren't for your, @Bluey26's and @javier-fuentes's comments, tests and patience, I could have done nothing. And Supposing that the problem has really been fixed, I can say that my suspicion was right: the cause was in front of my eyes.

I'll test more before jumping to conclusions

Yes, thanks! But at least we can say that something has really changed now :)

tsujan commented 8 months ago

I think this can be closed now.

The users who had encountered the issue should upgrade to Qps 2.8.0.