Add word characters preference option (fixes #1098)

lxqt / qterminal

A lightweight Qt-based terminal emulator

https://lxqt.github.io

GNU General Public License v2.0

586 stars 150 forks source link

Add word characters preference option (fixes #1098) #1101

Closed ahigerd closed 4 months ago

ahigerd commented 4 months ago

gnome-terminal supports configuring word selection characters, but QTerminal doesn't. This PR adds a configuration option to address that shortcoming.

I was going to make a feature request, but I found this feature request that beat me to it. @yan12125 had a partial implementation that I referenced, but I discovered that it was going to require a change to QTermWidget as well.

QTermWidget dependency: https://github.com/lxqt/qtermwidget/pull/531

yan12125 commented 4 months ago

Thanks!

ahigerd commented 4 months ago

Whoops. I found a bug in this PR: When the preference is changed, it isn't saved to disk, so it only persists as long as QTerminal is running. I only noticed this because I rebooted yesterday.

I'll get a fix in later once I have time to sit down with it when I'm not at work.