search

lxqt / qterminal

A lightweight Qt-based terminal emulator
https://lxqt.github.io
GNU General Public License v2.0
586 stars 150 forks source link

Fixed inactive tab text with Qt6 #1116

Closed tsujan closed 2 months ago

tsujan commented 2 months ago

Due to a change (or bug?) in Qt6, using a stylesheet for setting the font of active/inactive tabs doesn't work as it did with Qt5.

Here, QStyle is used directly, which is always the best approach because stylesheets can interfere with the widget style in bad ways.

Fixes https://github.com/lxqt/qterminal/issues/1112

tsujan commented 2 months ago

@yan12125 This is needed before releasing Qt6 QTerminal.

luis-pereira commented 2 months ago

Works as described with 6.6.2.

yan12125 commented 2 months ago

Thanks! Although I don't fully understand QStyle, I trust your expertise.

tsujan commented 2 months ago

@yan12125, Any estimation about when QTerminal 2.0.0 can be released? I haven't found any performance issue so far, but it may be better to silence compilation warnings before releasing.

yan12125 commented 2 months ago

I have some local changes for minor fixes and improvements, which should be finished in one or two days. Besides that, I'm waiting for https://github.com/lxqt/qterminal/pull/1110 and https://github.com/lxqt/qtermwidget/pull/540.