search

lxqt / qterminal

A lightweight Qt-based terminal emulator
https://lxqt.github.io
GNU General Public License v2.0
598 stars 150 forks source link

Update build.sh #1122

Closed stefonarch closed 4 months ago

stefonarch commented 4 months ago

Will still fail as qtermwidget-git doesn't exist yet. EDIT: probably not true.

yan12125 commented 4 months ago

As a record, I gave up maintaining LXQt *-git packages used in CI (https://github.com/archlinuxcn/repo/issues/3787). If you want to keep CI alive, you'll need to refresh -git packages first. See also https://github.com/lxqt/lxqt/issues/1644#issuecomment-2076343537 about concerns for the current approach.

stefonarch commented 4 months ago

I didn't remember where to look for your comments, thanks.

tsujan commented 4 months ago

If you want to keep CI alive...

CI was annoying to me from the start, although I learned how to tolerate it ;) I may be wrong, but I don't remember a single case where it has been really useful.

yan12125 commented 4 months ago

I don't remember a single case where it has been really useful.

It was useful when qtermwidget was ported to Qt 6 (https://github.com/lxqt/qtermwidget/pull/532). At that time nobody tested the port with PyQt, and CI became a good reminder.

Anyway, the current CI approach brings more issues than it solves.

stefonarch commented 4 months ago

but I don't remember a single case where it has been really useful

I remember that once I made a translation PR which went trough and blocked compiling, that was before weblate which prevents malformatted files. But as usually we compile all PRs locally we could do without CI.

I admire the CI of labwc which checks compiling on I don't know how many platforms, but that's one small binary which compiles here in 15 seconds or less.

stefonarch commented 4 months ago

Atm I disabled CI testing in QTerminal and lxqt-panel.