search

lxqt / qterminal

A lightweight Qt-based terminal emulator
https://lxqt.github.io
GNU General Public License v2.0
606 stars 151 forks source link

QTerminal should have libayatana-indicator and have smaller size icons #494

Open shirishag75 opened 6 years ago

shirishag75 commented 6 years ago

QTerminal doesn't use any indicator or have anything in the mate-notification area.

Having no notification or/and indicator means a user is never sure whether the app. is running or not.

See https://wiki.debian.org/Ayatana/IndicatorsTransition

and the difference between QTerminal and variety ( a wallpaper downloader and changer I like) 

$ dpkg -L qterminal | grep png
/usr/share/icons/hicolor/64x64/apps/qterminal.png

$ dpkg -L variety | grep png
/usr/share/icons/hicolor/22x22/apps/variety-indicator-dark.png
/usr/share/icons/hicolor/22x22/apps/variety-indicator.png
/usr/share/variety/media/tray-screenshot.png
/usr/share/variety/media/variety-indicator-dark.png
/usr/share/variety/media/variety-indicator.png
/usr/share/variety/media/variety128.png
/usr/share/variety/media/variety14.png
/usr/share/variety/media/variety16.png
/usr/share/variety/media/variety16a.png
/usr/share/variety/media/variety24.png
/usr/share/variety/media/variety256.png
/usr/share/variety/media/variety32.png
/usr/share/variety/media/variety48.png
/usr/share/variety/media/variety64.png
/usr/share/variety/media/vrty-cloud.png
/usr/share/variety/media/vrty-login.png
/usr/share/variety/media/vrty-users.png

Apparently the piece of code variety used to have indicator-support.

https://github.com/varietywalls/variety/commit/9d5d57e07af073d75b035e9b532ef5c5711eb318

yan12125 commented 5 years ago

From the screenshot at https://ayatanaindicators.github.io/about/, I think it's what QSystemTrayIcon provides? Now the question is: what should the icon do?

have smaller size icons

Providing an SVG icon might be a solution.

tsujan commented 5 years ago

My 2 cents: cluttering the systray (notification area) unnecessarily isn't a good idea. There should be good reasons to add systray functionality to an app; knowing whether it's running or not isn't one of them.