lxqt / qtermwidget

The terminal widget for QTerminal
https://lxqt.github.io
GNU General Public License v2.0
498 stars 254 forks source link

KDE/Konsole copyright notices #251

Open apjanke opened 5 years ago

apjanke commented 5 years ago

A lot of the source files in QTermWidget say they are part of Konsole or KDE.

[~/local/repos/qtermwidget]
$ grep -r "This source file is part of" *  
lib/ColorScheme.cpp:    This source file is part of Konsole, a terminal emulator.
lib/KeyboardTranslator.cpp:    This source file is part of Konsole, a terminal emulator.
lib/ColorScheme.h:    This source file is part of Konsole, a terminal emulator.
lib/KeyboardTranslator.h:    This source file is part of Konsole, a terminal emulator.
[~/local/repos/qtermwidget]
$ grep -r "This file is part of" * | head -10
lib/kptydevice.cpp:   This file is part of the KDE libraries
lib/Pty.h:    This file is part of Konsole, KDE's terminal emulator.
lib/BlockArray.cpp:    This file is part of Konsole, an X terminal.
lib/kprocess.cpp:    This file is part of the KDE libraries
lib/kprocess.h:    This file is part of the KDE libraries
[...]

That's not really accurate here, is it, since you've copied all these files into the QTermWidget project? And it will become less accurate as changes are made to those files.

What do you think of removing all the "This file is part of ..." lines, just leaving the copyright and license notices?

yan12125 commented 5 years ago

How do you think @agaida?

agaida commented 5 years ago

I'm biased - the files was forked long time ago and might differ from the current development - so i guess a short message "was forked from KDE $version $date would make sense" - and ofcourse the original copyright should remain intact.

agaida commented 5 years ago

Second thought - in a perfect world i would like to use the libs directly if possible and wrap around it in our own programming.

yan12125 commented 5 years ago

Hmm that reminds me of another form of copyright notice:

20XX-20YY Foo devs
20YY-20ZZ Bar devs

@agaida's suggestion is also good.

And in a perfect word konsole can be built with necessary KDE libraries only (e.g., KPty), and there will be no qterminal :)