search

lxqt / qtermwidget

The terminal widget for QTerminal
https://lxqt.github.io
GNU General Public License v2.0
485 stars 247 forks source link

pty fallback term #511

Closed luis-pereira closed 1 year ago

luis-pereira commented 1 year ago
yan12125 commented 1 year ago

Looks like this fixed https://github.com/lxqt/qtermwidget/issues/447 ?

luis-pereira commented 1 year ago

Yes, it fixes it as "secondary" effect. Default TERM from qterminal needs to be set in qtermwidget. Will check how to do that.

yan12125 commented 1 year ago

qterminal sets TERM via qputenv. Other applications may do something similar. Looks like this approach overwrites existing environment variables?

luis-pereira commented 1 year ago

qterminal sets TERM via qputenv. Other applications may do something similar. Looks like this approach overwrites existing environment variables?

@yan12125 Is there any downside to https://github.com/lxqt/qterminal/pull/1058 ?

luis-pereira commented 1 year ago

@yan12125 xterm is a even more sensible fallback.

yan12125 commented 1 year ago

Is there any downside to https://github.com/lxqt/qterminal/pull/1058 ?

For qterminal, I don't think so. There might still be an issue for other applications that embed qterm widget. Could you add some sentences to https://github.com/lxqt/qtermwidget/blob/master/CHANGELOG to clarify that?

By the way, https://github.com/lxqt/qterminal/issues/406 may be fixed as a side effect.

xterm is a even more sensible fallback.

I prefer xterm-256color. qtermwidget already supports most of commonly-used features in xterm-256color.

luis-pereira commented 1 year ago

For qterminal, I don't think so. There might still be an issue for other applications that embed qterm widget. Could you add some sentences to https://github.com/lxqt/qtermwidget/blob/master/CHANGELOG to clarify that?

Ok. Will do that. What issue for apps that embed qtermwidget ? If they don't set TERM, qtermwidget set it to xterm-256color as a fallback. A method to explicilty do that can be added.

By the way, lxqt/qterminal#406 may be fixed as a side effect.

Good. I wasn't even aware of https://github.com/lxqt/qterminal/issues/406.

I prefer xterm-256color. qtermwidget already supports most of commonly-used features in xterm-256color.

Agrreed.

yan12125 commented 1 year ago

If an application sets TERM by qputenv (like the current qterminal), will it be overwritten? If so, a migration hint is good.

yan12125 commented 1 year ago

Thanks! I use rebase instead of squash as the first commit is a different improvement.