search

lxqt / qtermwidget

The terminal widget for QTerminal
https://lxqt.github.io
GNU General Public License v2.0
485 stars 247 forks source link

Make lxqt-build-tools optional #514

Closed bog-dan-ro closed 9 months ago

bog-dan-ro commented 9 months ago

It's useful to build it on platforms such Android

yan12125 commented 9 months ago

Is there an issue with lxqt-build-tools on Android?

bog-dan-ro commented 9 months ago

Yes, it's not available nor needed 😉.

yan12125 commented 9 months ago

It's needed for translation files, which are important for user experience. Could you share more about unavailability? Some package managers include it (ex: termux), and installing it from sources should be straightforward as well.

tsujan commented 9 months ago

My 2 cents: the problem isn't in QTerminal. Either it's a packaging problem or, if lxqt-build-tools really can't be compiled for Android, an issue in lxqt-build-tools or even Qt.

bog-dan-ro commented 9 months ago

The idea is to open this project in qtcreator set an android kit and run it. Without lxqt-build-tools you can't do it. If lxqt-build-tools are not found and if they are really needed, then IMHO, it should use FetchContent_Declare to automatically get it.

Anyway for my project I end up using QtCreator's terminal emulator which I could run it on Android with Qt6 in no time.

yan12125 commented 9 months ago

There are a few issues/pull requests mentioning Qt creator. I assume using lxqt-build-tools is already possible.

If lxqt-build-tools are not found and if they are really needed, then IMHO, it should use FetchContent_Declare to automatically get it.

Feel free to update this PR or open another PR to improve the workflow with Qt creator. I don't use Qt creator, so I may not do it by myself in near future.

yan12125 commented 9 months ago

Let's continue the work in another PR.