search

lxqt / qtermwidget

The terminal widget for QTerminal
https://lxqt.github.io
GNU General Public License v2.0
485 stars 247 forks source link

Rebased qgis fixes #516

Closed luis-pereira closed 9 months ago

luis-pereira commented 9 months ago

A rebase of https://github.com/lxqt/qtermwidget/pull/499 PR

yan12125 commented 9 months ago

Looks good overall. Just curious - is it possible to get rid of assertWithSideEffect by changing some member functions to const?

luis-pereira commented 9 months ago

Looks good overall. Just curious - is it possible to get rid of assertWithSideEffect by changing some member functions to const?

Sorry for the long delay. It's possible and done with commit https://github.com/lxqt/qtermwidget/pull/516/commits/634e66e39666a1e9da715295711cb9ffa5bb58fe.

yan12125 commented 9 months ago

Thank you! I merge this without squashing as those changes are kind of independent, and thus squashing may make git blame harder.

Sorry for the long delay.

A few days is short for me :)

luis-pereira commented 9 months ago

Thank you! I merge this without squashing as those changes are kind of independent, and thus squashing may make git blame harder.

It would make history a lot harder to understand.

yan12125 commented 9 months ago

In my opinion, this is a good trade-off - easier debugging (ex: via git bisect) is more important than simpler history.