lxqt / screengrab

Crossplatform tool for fast making screenshots.
https://lxqt.github.io
GNU General Public License v2.0
71 stars 45 forks source link

Qt6 port #360

Closed tsujan closed 3 months ago

tsujan commented 3 months ago

@stefonarch Please check all kinds of screenshots as well as Edit in... and saving under X11.

Chiitoo commented 3 months ago

Similar to somewhere else, I hit a few header issues in core.cpp and in extedit.h:

src/core/core.cpp:33:10: fatal error: qt5xdg/XdgDesktopFile: No such file or directory
   33 | #include <qt5xdg/XdgDesktopFile>
      |          ^~~~~~~~~~~~~~~~~~~~~~~

Also, my mouse pointer does not seem to get included when the option is enabled, but I'm not sure if that worked before?

Thank you!

stefonarch commented 3 months ago

Also, my mouse pointer does not seem to get included when the option is enabled, but I'm not sure if that worked before?

This did work before, tested under debian VM with 1.4 now. Retesting...

EDIT: mouse cursor is included here, both in fullscreen and window mode.

tsujan commented 3 months ago

@stefonarch Please check again. I removed "USE_QT..." and fixed the header of qt6xdg.

Chiitoo commented 3 months ago

Forgot to mention that was on KWin X11, and yeah, I see it now too, in another clean-user session.

This other session might be a bit... slightly messed up right now but I'll try to see what is going on with the cursor later.

tsujan commented 3 months ago

@Chiitoo Please test it again (I added a commit).

Similar to somewhere else,...

Yes. Supporting two versions of Qt — even in the minimal way we do it (only for styling and file dialog) — can be confusing. It should be fixed now.

Chiitoo commented 3 months ago

@Chiitoo Please test it again (I added a commit). Yes. Supporting two versions of Qt — even in the minimal way we do it (only for styling and file dialog) — can be confusing. It should be fixed now.

Indeed!

All good now here too.

tsujan commented 3 months ago

@Chiitoo Thanks! Your tests have saved us a lot of headache twice :)

tsujan commented 3 months ago

Will merge it tomorrow, after re-reading the changes.