search

lxqt / sddm-config-editor

SDDM Configuration Editor
Apache License 2.0
63 stars 16 forks source link

Replace QML with Widgets #23

Closed agaida closed 5 years ago

agaida commented 5 years ago

I guess that would be fit better with LXQt - it will solve some problems with the current QML implementation too - sddm-config-editor spams a lot of messages to the xsession log - so the question is, if it is worth to fix these things or just to base the UI on something we know as working well

@tsujan @palinek

tsujan commented 5 years ago

We have no QML; do we? sddm-config-editor is in QML?

tsujan commented 5 years ago

Yes, it is. Tell me when I should run away from LXQt!

agaida commented 5 years ago

hihihi - keep calm - we only have to change some ui bits :D

agaida commented 5 years ago

erm - the whole ui - we wanted a ui for sddm, we aquired one - and knowed that it wasn't written with LXQt in mind

tsujan commented 5 years ago

keep calm

I try, when, from my superficial viewpoint, I compare this QML combo-box:

1

with this QComboBox:

2

Who says GUI is important?

tsujan commented 5 years ago

QML is most attractive with a dark gtk2 widget style:

3

agaida commented 5 years ago

the answer is easy - if not happy with the current state - change it

tsujan commented 5 years ago

Today I'm very happy. I don't know about tomorrow.

agaida commented 5 years ago

@tsujan - i don't have any plans to release sddm-config-editor pre-mature. With done i mean - no QML, overhauled interface, overhauled functionality if needed. Lesson learned: It is done when it is done.

tsujan commented 5 years ago

Converting it to a real Qt/C++ app should be easy. I'll try to do it later but not very soon.

agaida commented 5 years ago

take your time