search

lxqt / xdg-desktop-portal-lxqt

A backend implementation for xdg-desktop-portal
GNU Lesser General Public License v2.1
20 stars 8 forks source link

Require exif #11

Open jubalh opened 2 years ago

jubalh commented 2 years ago

I don't see where we use that in the code but without this I get:

[    4s] AutoMoc: Generating MOC compilation "SRC:/build/src/xdg-desktop-portal-lxqt_autogen/mocs_compilation.cpp"
[    4s] AutoGen: Writing the parse cache file "SRC:/build/src/CMakeFiles/xdg-desktop-portal-lxqt_autogen.dir/ParseCache.txt"
[    4s] AutoGen: Writing the settings file "SRC:/build/src/CMakeFiles/xdg-desktop-portal-lxqt_autogen.dir/AutogenUsed.txt"
[    4s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build'
[    4s] make[1]: Entering directory '/home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build'
[    4s] [ 12%] Built target xdg-desktop-portal-lxqt_autogen
[    4s] make[1]: Leaving directory '/home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build'
[    4s] /usr/bin/make  -f src/CMakeFiles/xdg-desktop-portal-lxqt.dir/build.make src/CMakeFiles/xdg-desktop-portal-lxqt.dir/depend
[    4s] make[2]: Entering directory '/home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build'
[    4s] cd /home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0 /hom↪ e/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/src /home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build /home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build/sr↪ c /home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build/src/CMakeFiles/xdg-desktop-portal-lxqt.dir/DependInfo.cmake
[    4s] make[2]: Leaving directory '/home/abuild/rpmbuild/BUILD/xdg-desktop-portal-lxqt-0.2.0/build'
[    4s] /usr/bin/make  -f src/CMakeFiles/xdg-desktop-portal-lxqt.dir/build.make src/CMakeFiles/xdg-desktop-portal-lxqt.dir/build
[    4s] make[2]: *** No rule to make target '/usr/lib64/libexif.so', needed by 'src/xdg-desktop-portal-lxqt'.  Stop.
tsujan commented 2 years ago

There's no need to that. xdg-desktop-portal-lxqt depends on libfm-qt, which depends on libexif.

jubalh commented 2 years ago

I used BuildRequires: pkgconfig(libfm-qt) >= 1.1.0 but only when I added libexif it built. But if you are certain then we can close this (as I added it to the spec file). So on my side the problem is solved.

stefonarch commented 2 years ago

libexif;)

tsujan commented 2 years ago

Let's wait for @palinek.

palinek commented 2 years ago

Hm...then isn't something wrong with dependencies propagation from libfm-qt?

jubalh commented 2 years ago

Probably that would make more sense.