search

lxqt / xdg-desktop-portal-lxqt

A backend implementation for xdg-desktop-portal
GNU Lesser General Public License v2.1
20 stars 8 forks source link

filechooser: Add support for check/combo "choices" #5

Closed palinek closed 2 years ago

palinek commented 2 years ago

Adding additional widget into QFileWidget is not possible, when the platform-native file dialog is used. Therefore we need to use the Fm::FileDialog directly.

palinek commented 2 years ago

@stefonarch Can you, please, test this? Just if you don't spot any regression.

After this is merged, I believe, we can make a release.

stefonarch commented 2 years ago

Does this depend on a branch in libfm-qt?

stefonarch commented 2 years ago

Anyway, I noticed (not sure if this is also in master) an overkill in regular expressions in file save dialog:

schermata-02-02-14-51 schermata-02-02-14-52

Most people never saw this.

palinek commented 2 years ago

an overkill in regular expressions in file save dialog

We don't anyhow touch those values, that's what is coming from the application, which is using the xdg-portal interface.

stefonarch commented 2 years ago

I see. In the default filedialog (in thunderbird and firefox) there is just the linedit with name_of_file.[extension]. So we cannot touch those values, or not show them at all (best IMO)?

tsujan commented 2 years ago

After this is merged, I believe, we can make a release.

Tell me when it's ready and I'll make a release.

palinek commented 2 years ago

So we cannot touch those values, or not show them at all (best IMO)?

We can't... -> https://doc.qt.io/qt-5/qfiledialog.html#setNameFilters