lxqt / xdg-desktop-portal-lxqt

A backend implementation for xdg-desktop-portal
GNU Lesser General Public License v2.1
20 stars 8 forks source link

Settings saved/applied using the plain libfm-qt's file dialog #7

Closed palinek closed 2 years ago

palinek commented 2 years ago
Expected Behavior

File dialog provided by xdg-desktop-portal-lxqt should behave the same way as the LXQt native file dialog in Qt apps.

Current Behavior

With current implementation we don't use the Fm:FileDialogHelper and loosing its functionality, e.g. applying & saving preferences.

Possible Solution

Make use of the Fm:FileDialogHelper to not copy-paste its logic into our code.

Steps to Reproduce (for bugs)
  1. invoke open/save dialog
  2. change some settings (size, icon sizes, etc.)
  3. close dialog
  4. invoke open/save dialog & observe previous settings lost
Context

I will submit PRs for libfm-qt, and xdg-desktop-portal-lxqt

System Information
stefonarch commented 2 years ago

Actually here setting are all preserved on reopening (with libfm-qt helper-extend-api)

stefonarch commented 2 years ago

I noticed that now localization is broken: english and smaller window. no clue when this started. Rebooted also. Will open an issue when I've more substance about.