search

lxqt / xdg-desktop-portal-lxqt

A backend implementation for xdg-desktop-portal
GNU Lesser General Public License v2.1
20 stars 8 forks source link

filechooser: Use Fm:FileDialogHelper #8

Closed palinek closed 2 years ago

palinek commented 2 years ago

By usage of Fm::FileDialogHelper we will get the "native LXQt" feel, as the helper is applying & saving preferences. This way apps using xdg-portal will behave like the native Qt apps under LXQt.

This needs lxqt/libfm-qt#777

Closes #7

stefonarch commented 2 years ago

This can be merged now no?

palinek commented 2 years ago

Well, not directly as we set the requirements here to set(LIBFMQT_MINIMUM_VERSION "1.0.1") which didn't happen. So I would merge this just before the 1.1 release.

stefonarch commented 2 years ago

I noticed this after posting, changed it back to 1.0.0 and compiled it to get rid of the small window every time, but I see that window size and settings are working fine, but localisation does not (anymore) - still in english. https://github.com/lxqt/xdg-desktop-portal-lxqt/issues/9

palinek commented 2 years ago

It depends how is your xdg-desktop-portal-lxqt process started. If it doesn't have LANG/LANGUAGE env. vars correctly set, then there will be no translation.

stefonarch commented 2 years ago

I remember that previously it just worked. I had now

env |grep LANG
LANGUAGE=
LANG=it_IT.UTF-8

added LANGUAGE=it in lxqt-session but id didn't change anything, rebooted and still english.

palinek commented 2 years ago

Try to get the env of the process:

$ strings /proc/$(pgrep -f '^[^[:space:]]*xdg-desktop-portal-lxqt')/environ | egrep LANG
stefonarch commented 2 years ago

Checked on the other PC, it works fine there with same LANG settings. Forget about please, will investigate.

stefonarch commented 2 years ago

$ strings /proc/$(pgrep -f '^[^[:space:]]*xdg-desktop-portal-lxqt')/environ | egrep LANG

In fact, on my laptop this returnsLANG=C

palinek commented 2 years ago

In fact, on my laptop this returns LANG=C

There you go.

tsujan commented 2 years ago

Well, not directly as we set the requirements here to set(LIBFMQT_MINIMUM_VERSION "1.0.1") which didn't happen. So I would merge this just before the 1.1 release.

Since it'll be in LXQt 1.1.0, LIBFMQT_MINIMUM_VERSIONcan be 1.1.0.

I set the versions in "prerelease" PRs.

stefonarch commented 2 years ago

In fact, on my laptop this returns LANG=C

There you go.

I still didn't solve the issue. I noticed now that also the native filepicker from firefox/thunderbird is displayed english. Other users have the same issue, so it's somewhere in the system.

stefonarch commented 2 years ago

This morning I had a suspect and checked:

cat /etc/locale.conf                                                 
# This is the fallback locale configuration provided by systemd.

LANG="C"

that was the reason, but the only affected thing was desktop portal over all those months.

tsujan commented 2 years ago

LANG="C"

It happened in Manjaro last week. Someone had decided to make it so without thinking about the consequences, which weren't limited to translations.

stefonarch commented 2 years ago

It's on arch (but it was originally a manjaro installation) - my guess is that here it was always like that, for months I had the english filedialog in firefox.

tsujan commented 2 years ago

/etc/locale.conf and /etc/locale.gen were overwritten during an upgrade — something that shouldn't happen to an Arch system because .pacnew exists. I rebooted to check its probable effects. The damaged bash prompt in qterminal and xterm was alarming; so, I restored LANG=en_US.UTF-8.

The problem was related to a change in systemd, which never stops causing troubles.

stefonarch commented 2 years ago

Just noticed that you ported featherpad to qt6! I've a clean new install and no wip6 branches yet. It has tiny tiny font on the toolbar :)

tsujan commented 2 years ago

Just noticed that you ported featherpad to qt6!

Its default compilation is still for Qt5, but the Arch package is compiled against Qt6, which is good IMO.

I've a clean new install and no wip6 branches yet. It has tiny tiny font on the toolbar :)

With the Qt6 branches, I see no difference in Qt6 apps except for fonts. Qt6 has fixed a longstanding bug in text alignment but reduced font heights by 2px or so (it may depend on the font). Therefore, with a good Qt6 support (like that of Qt6 branches), GUI texts seem a little more compact vertically. I'm not sure if this difference is caused by a bug in Qt6 or in Qt < 6.

In git Kvantum, I've compensated for it by adding 2px to GUI text heights with Qt6.