World menu item ‘Terminal’ doesn’t run one’s preferred shell

[Rinzwind]

The world menu item ‘Terminal’ always runs /bin/bash, it would be nicer if it used one’s preferred shell.

On macOS, /bin/bash was used as the default login shell until macOS Catalina, which changed it to /bin/zsh: see the Apple support article “Use zsh as the default shell on your Mac”. I do still use Bash myself, but as /bin/bash is v3.2.57 on macOS Big Sur, I installed a newer version from MacPorts and used chsh to set that version as my login shell.

I’m not sure what the best approach is for the menu item:

• Use the ‘SHELL’ environment variable, which seems to be what xterm does, so:

  TerminalEmulator open: (OSEnvironment current at: 'SHELL' ifAbsent: [ '/bin/sh' ])
      arguments: #()

• Use ‘login’, which seems to be what Terminal on macOS does, so:

  TerminalEmulator open: '/usr/bin/login'
      arguments: { '-f'. OSEnvironment current at: 'LOGNAME' }