lxsmnsyc / solid-styled

Reactive stylesheets for SolidJS
MIT License
177 stars 11 forks source link

resepect postcss plugins? #24

Closed asaf closed 1 year ago

asaf commented 1 year ago

Hey,

I have a Vite based project with postcss.config.cjs that have some plugins, Since this package is postcss based, would it be possible to respect the postcss plugins as well?

Thanks.

lxsmnsyc commented 1 year ago

It's actually no longer postcss-based, see: https://github.com/lxsmnsyc/solid-styled?tab=readme-ov-file#css-processing

But, if it was still in postcss, there's no room for plugins to be supported because that requires async processing, which is not possible because Babel can only run synchronously. A lot of people who tried this had implemented a solution that isn't universal (the solution being running the async task on a separate process and making it so that it runs sync on the main process), so I never really reconsidered it.

asaf commented 1 year ago

Fair enough, I personally needed the custom media queries and nesting which seems to be supported in LightningCSS,

I get: [plugin:solid-styled] custom media query --foo is not defined, I tried ti define them in my root component's using @global but it doesn't wok (maybe related to https://github.com/lxsmnsyc/solid-styled/issues/18)

Thanks for the great work, I like the style of this plugin!

lxsmnsyc commented 1 year ago

Yeah I'll give this a maintenance run again. The thing is, I'm not sure if LightningCSS has already fixed the said issue.

asaf commented 1 year ago

I'm closing this in favor of #18