search

lxsmnsyc / solid-tiptap

SolidJS bindings for tiptap
MIT License
114 stars 3 forks source link

[Feature request] Wrapper for Node views #1

Open mirus-ua opened 2 years ago

mirus-ua commented 2 years ago

Hi. I'm playing around with solidjs and trying to figure out which editor should I use for a project. Tiptap looks great and solid-tiptap also is handy, but I found that the library doesn't have any wrapper for solid components. The simplest example of why this is important is the possibility to use components libraries such as hope-ui.

I could even help if you'll give me a direction because I'm new in solid and tiptap ecosystem

lxsmnsyc commented 2 years ago

Thanks for showing interest. I'm not sure what it means to have a wrapper for Solid Components (or rather Node View, not sure how related they are to one another) and perhaps you can give me an example on how would it work?

mirus-ua commented 2 years ago

I'm saying about a possibility like react https://tiptap.dev/guide/node-views/react Rendering solid components inside the text editor will increase the flexibility of the library

lxsmnsyc commented 2 years ago

I'm saying about a possibility like react https://tiptap.dev/guide/node-views/react

Rendering solid components inside the text editor will increase the flexibility of the library

I might have missed this before, thanks! I'll take a look at this

amirhhashemi commented 1 year ago

Hi @lxsmnsyc. Any progress? I need this in my project and I'm trying to implement it. Just wanted to make sure we don't work on the same thing simultaneously.

lxsmnsyc commented 1 year ago

I haven't really explored Tiptap again since last year. I'm open for PRs though

eugenejeonme commented 1 year ago

I needed it too, so I wrote some code. (*Written by forking this repository)

If you need to, you can create a PR.

Repository URL : https://github.com/EugeneJeonME/solid-tiptap/tree/SolidNodeViewRenderer

image image
liuyike98 commented 1 year ago

@EugeneJeonME i'm also doing work for this, glad to see that you have finish this! save me a lot of time, i will try it soon :)

shiro commented 1 year ago

I've tested the code and didn't find any bugs so far, it works perfectly and allows rendering solid components in the editor!

Any plans to merge that back into this repository?

eugenejeonme commented 1 year ago

@mirus-ua @amirhhashemi @liuyike98 @shiro You have created a PR. #9 This should work fine, right?

Ladvace commented 1 year ago

Any update?

camplowell commented 5 days ago

@lxsmnsyc Any updates on this? I understand if this project is on the back burner, but last I saw the PR just kind of disappeared because Eugene deleted his fork - your last comment on the PR seemed positive, but nothing seems to have happened since.