Closed xcariba closed 4 years ago
pisv
commented
4 years ago Just a note that I have started processing the patch. There is a build error, but please don't do anything about it as it may interfere with my work on the patch. I'll fix it myself and let you know when my processing is complete. Thank you!
pisv
commented
4 years ago I squashed the commits, made a rebase and pushed the result to the genesis branch. Thanks for the contribution; it is much appreciated!
Minor notes:
Please use LXTK-specific Java Formatter settings. The formatting profile is available at tools/formatter.xml. It would make reviewing and processing the patch a bit easier. To save a roundtrip, I re-formatted the code myself.
TM2E requires org.jcodings and org.joni. I added both to the target platform.
TM2E 0.3.4 includes org.eclipse.tm4e.languageconfiguration 0.3.3, which resulted in build error "Unsatisfied version constraint: 'org.eclipse.tm4e.languageconfiguration: [0.3.4,1.0.0]'" at MANIFEST.MF in org.lxtk.lx4e.examples.json. I fixed that.
Also, I elaborated a bit on the preferences story, as, in its current form, JsonEditor attempted to set default values in a preference store for another plugin, org.eclipse.ui.editors. I added a couple of classes, JsonPreferenceConstants and JsonPreferenceInitializer to handle that.
Added simple TM4E-based syntax highlight for JSON example. It has simple grammar and language configuration that enables character pair metching and auto-closing pairs.