search

lxtk-org / lxtk

Language Client/Server Toolkit
Eclipse Public License 2.0
33 stars 2 forks source link

Refactor logging to more modern and less verbose way #6

Closed masofcon closed 4 years ago

masofcon commented 4 years ago

There is modern methods for logging :)

https://git.eclipse.org/r/#/c/148261/12/bundles/org.eclipse.core.runtime/src/org/eclipse/core/runtime/ILog.java

pisv commented 4 years ago

Anyway, thanks for noting that! :-)

masofcon commented 4 years ago

Yeah, I know :-) It is just that they are too modern to our taste ;-)

@since 3.17 while our base target contains org.eclipse.core.runtime 3.14

Oh! My bad! Feel free to decline it :)

p.s. may be we need build against both targets?

pisv commented 4 years ago

p.s. may be we need build against both targets?

Personally, I use a workspace with the base target for development, which does not allow me to import anything from newer versions. So, to me, it does look like a pressing issue. But it would not hurt to build against both targets, either.