search

lxxxvi / ruboclean

Ruby gem that puts `.rubocop.yml` into order.
MIT License
18 stars 4 forks source link

Update rubocop_configuration_path.rb #15

Closed danlo closed 8 months ago

danlo commented 1 year ago

Allow ruby 3.0 un-authorized classes.

lxxxvi commented 1 year ago

Hi @danlo

Thank you for your contribution! 👍

Would it be possible to add tests for it? May be you can add example configuration to test/fixtures/00_input.yml for Regexp and Symbol?

Thanks!

lxxxvi commented 1 year ago

Hi @danlo 👋

I released a new version 0.3.0 that permits Regexp. I was not so sure about permitting Symbol as well, since I couldn't find any Rubocop configuration that would expect Symbol... can you point me to an example? Thanks.

danlo commented 1 year ago

I don't know of any. I included it because I often use symbols often in my yaml files.

-Daniel

On Wed, Jan 4, 2023, 2:28 AM Mario @.***> wrote:

Hi @danlo https://github.com/danlo 👋

I released a new version 0.3.0 that permits Regexp. I was not so sure about permitting Symbol as well, since I couldn't find any Rubocop configuration that would expect Symbol... can you point me to an example? Thanks.

— Reply to this email directly, view it on GitHub https://github.com/lxxxvi/ruboclean/pull/15#issuecomment-1370747365, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEAG7J7GQ2QWH7JAPFH5E3WQVGF3ANCNFSM6AAAAAATGEU2U4 . You are receiving this because you were mentioned.Message ID: @.***>

lxxxvi commented 8 months ago

@danlo Closing this PR after ~1 year of inactivity, hope that's OK.