search

ly4k / Certipy

Tool for Active Directory Certificate Services enumeration and abuse
MIT License
2.34k stars 318 forks source link

Update setup.py #157

Open Blyth0He opened 1 year ago

Blyth0He commented 1 year ago

the latest version of requests(2.31.0) shipped with urllib3 2.0.4 leads to an error as follow when using -web options:

[!] Failed to connect to Web Enrollment interface: _http_request() got an unexpected keyword argument 'chunked'

AdrianVollmer commented 11 months ago

Please don't put upper limits on dependencies, especially on popular libraries like requests. This will exacerbate dependency hell.

Here is how docker fixed the underlying issue: https://github.com/docker/docker-py/issues/3113

This is the fix: https://github.com/docker/docker-py/pull/3117/files

So we probably need to change https://github.com/ly4k/Certipy/blob/2780d5361121dd4ec79da3f64cfb1984c4f779c6/certipy/commands/relay.py#L45 accordingly.