search

ly95 / vsc.php-symbols

Support php symbols for VSCode.
http://ly95.github.io/vsc.php-symbols
MIT License
8 stars 0 forks source link

Runaway process when used on large files #10

Closed acb closed 7 years ago

acb commented 7 years ago

VSCode version: 1.8.1 Operating system: Ubuntu 14.04

As of this latest vscode version when I execute workbench.action.gotoSymbol on a large php file (1500+ lines) the symbols never appear and just have the loading bar go forever.

Additionally, when I close vscode there's still a code process that won't die unless I sudo kill it. That process also goes crazy on CPU, sitting at 100% CPU according to top until I kill it. If I don't kill the rogue process and restart vscode and try to use workbench.action.gotoSymbol on another large php file it will create another out of control process at 100% CPU and so on.

I unfortunately can't provide you with the files that are triggering this behavior since they're part of my company's source code. Since it happens on any of our large php files though I believe all you should need to reproduce is a 1,500 line or so php file with lots of functions declared.

heisjj commented 7 years ago

I'm running into this same issue, @acb. And I know another developer who is too, so it's fairly safe to assume it isn't specific to your files.

acb commented 7 years ago

@heisjj well it's good to know that it's not something weird with me! Do you happen to have a file on hand you could put in pastebin and link here? I figure it'll be easier for @ly95 to debug if we can just present a file that reproduces the issue.

heisjj commented 7 years ago

Sorry, @acb my situation is similar to yours. I can't post any files because it'd put my company's website at risk.

From: Aaron Cavanaugh-Broad notifications@github.com Sent: Wednesday, January 18, 2017 1:10 PM To: ly95/vsc.php-symbols Cc: heisjj; Mention Subject: Re: [ly95/vsc.php-symbols] Runaway process when used on large files (#10)

@heisjjhttps://github.com/heisjj well it's good to know that it's not something weird with me! Do you happen to have a file on hand you could put in pastebin and link here? I figure it'll be easier for @ly95https://github.com/ly95 to debug if we can just present a file that reproduces the issue.

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/ly95/vsc.php-symbols/issues/10#issuecomment-273602762, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANMyNxlVkaUW9BGdbfpnzNDtYdZkcvjiks5rTn_JgaJpZM4Ll8Vk.

ly95 commented 7 years ago

@acb @heisjj I will make some tests on ubuntu14. Thanks for report.

acb commented 7 years ago

@ly95 I just tested on another machine and found some information that might be helpful. I believe this old machine was on version 2.0.0 of your extension and it worked just fine, but updating to version 2.0.3 (the latest version) causes the bug to reappear.

This new machine is also running vscode 1.8.1 but is on Ubuntu 16.04, so it happens on both versions of Ubuntu.

As a workaround for now, is there a way we could manually download and install version 2.0.0? Thanks for your help!

ly95 commented 7 years ago

@acb @heisjj Hi all. Please upgrade the new version v2.1.0 , It can be work fine.

heisjj commented 7 years ago

@ly95 Thank you for creating and maintaining this plugin!

On Jan 21, 2017, at 7:48 PM, Yang Lin notifications@github.com<mailto:notifications@github.com> wrote:

@acbhttps://github.com/acb @heisjjhttps://github.com/heisjj Hi all. Please upgrade the new version v2.1.0 , It can be work fine.

- You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/ly95/vsc.php-symbols/issues/10#issuecomment-274306196, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ANMyN5D3gPpnKrqM1YML5VUni-KPAakzks5rUtGAgaJpZM4Ll8Vk.

acb commented 7 years ago

I just updated and it's working again! @ly95 thanks for your help!