search

ly95 / vsc.phpmd

VS Code extension for php, using phpmd.
MIT License
5 stars 2 forks source link

1.1.0 breaks composer support... #11

Open mizunashi-mana opened 8 years ago

mizunashi-mana commented 8 years ago

See, https://github.com/ly95/vsc.phpmd/blob/master/server/src/server.ts#L113

Composer support using '' as default executablePath value!

There are two ways to solve:

  1. Revert https://github.com/ly95/vsc.phpmd/commit/6a71b0b3f7e90468c31d97eb4f3b092b6cd954a7
  2. Modify https://github.com/ly95/vsc.phpmd/blob/master/server/src/server.ts#L113
mizunashi-mana commented 8 years ago

Thanks for fix (https://github.com/ly95/vsc.phpmd/commit/a07700c672d030adb224beb84159cb4550cd98a3).

However, it seems no release was appeared. (https://marketplace.visualstudio.com/items?itemName=linyang95.phpmd)

ly95 commented 8 years ago

Issues, if executablePath is empty will get error message.

mizunashi-mana commented 8 years ago

@ly95 Hmm... phpmd plugin is running without error on my VSCode(v1.0.0) if executablePath is empty...

However, start is slowly. The reason may be "composer support"... I will try to fix.

mizunashi-mana commented 8 years ago

Perhaps, It can be a resolver to change onInitialize to return Promise. However, we have no solutions to get config params on initialize... Many plugins seem to be not supported executablePath (maybe, the reason is such as...).

ly95 commented 8 years ago

It's not work fine, a directory without composer.

mizunashi-mana commented 8 years ago

@ly95 On my environment, working fine without composer. Are there any errors?

mizunashi-mana commented 8 years ago

Perhaps, we should create gitter room and talk about in that room.

ly95 commented 8 years ago

I will check again. Too busy recently. Sorry.

mizunashi-mana commented 8 years ago

@ly95 I see, thanks.