search

lyang / braintree-rails

MIT License
65 stars 22 forks source link

Add CreditCards number, cvv fields as updateable #4

Closed n0nick closed 11 years ago

n0nick commented 11 years ago

Since Braintree allows for these fields to be part of a call to update credit cards, I don't see a reason to leave them out.

This way, we're able to simulate a one-to-one Customer-CreditCard relation without diving into complex delete-and-create logic.

lyang commented 11 years ago

Thank you very much for the pull requests, @n0nick!

n0nick commented 11 years ago

Thanks @lyang for an awesome execution on this gem :) When do you think you'll be able to bump a version so I could get back to using it from rubygems?

Also, I just found another issue with CreditCard, will fire up a new issue.

lyang commented 11 years ago

I am currently working on the changlog from 1.0.0 to a next 1.1.0. Things I want to add before next release includes the bug fix you mentioned, better detection on the use of Braintee.js (encrypted values have a recognizable pattern).

So, hopefully the next release will be very soon.

n0nick commented 11 years ago

Cool, thanks! If I can help in any way please let me know.

lyang commented 11 years ago

Just started my working day (PDT), changes will probably be made after working hours. Thank you very much for all the feedbacks, keep them coming!