search

lyarenei / Medusic

An attempt to create a native iOS Jellyfin music client. Also a personal Swift/SwiftUI learning project I work on when I've got some free time (and motivation).
5 stars 0 forks source link

[Improvement] Remove volume control in current song detail screen #84

Closed MatyasKriz closed 5 months ago

MatyasKriz commented 6 months ago

IMO it would make more sense to exclude the volume control as it's simply connected to the system volume anyway which can be controlled by buttons/keys.

lyarenei commented 6 months ago

This could be said about all apps on ios, tbh. But then even apple chooses to show it, so I think there is a reason (probably something to do with accessibility). Personally I don't mind it there, it's not like it takes some precious space.

I'll make it configurable.

MatyasKriz commented 6 months ago

It might help if the volume slider was as slick as Apple's, but at the moment it's a basic component and it looks a bit off there.

lyarenei commented 6 months ago

I found out in #89 there's a way to hide the knob, so now (and with the speaker icons) it looks much better.

If there is a way to scale it on drag like the playback progress slider, then that would be awesome, but I have no idea how to do that in uikit.

lyarenei commented 5 months ago

I have decided to not allow hiding the volume bar after all. Now with the speaker icons added and knob gone, the volume bar looks much more presentable, especially after changes in #93:

Before:

After:

And not to mention it looks kind of weird without the volume bar at all.

Let me know what you think.

MatyasKriz commented 5 months ago

Yeah, it looks way better now. The spacing around the playback controls still feels a bit too large to me though, might be because of the monotonous background.

Actually it might be because in AM the album art casts shadow and the text below is positioned lower.

lyarenei commented 5 months ago

I think at this point it's just a catch 22. You will either have an empty space or obnoxiously big elements, especially on bigger screens. So, I think empty space is just the lesser evil and I went with that - at least for the time being. Unless of course there are more tricks to make the UI look nice regardless of the (reasonable range of) screen sizes.