search

lyarenei / jellyfin-plugin-itunes

Apple Music metadata provider for Jellyfin
GNU General Public License v3.0
9 stars 0 forks source link

Use language of song/album/library when using link #8

Open StayBlue opened 2 months ago

StayBlue commented 2 months ago

By default, the plugin uses music.apple.com/us. My proposal involves checking the current language of the song/album/library (in that order of precedence) when driving the metadata instead. This allows the metadata to be based on the language instead of always being in English.

lyarenei commented 4 weeks ago

@StayBlue This should be now implemented in #9, if you want, you can test it by either downloading the build from the CI jobs or you can temporarily switch to my dev repo (https://repo.xkrivo.net/jellyfin-dev/manifest.json) and install plugin version 2.1.0.0

One thing to note, as Apple Music is region based, the language is decided by the region field in metadata, not the laguage field itself.

StayBlue commented 1 week ago

Couldn't the "Country/Region" field in the library be used? Sometimes the songs aren't tagged properly.

lyarenei commented 2 days ago

@StayBlue As far as I know, the field is only for metadata language settings and has nothing to do with Language tag in the song file metadata. Or at least I have never seen this field set on my server despite having all my music tagged with Picard. Except when I set it explicitly for testing these changes.

Otherwise the priority should be hierarchical, with song level having the highest priority and server global settings having the least priority. So as long as the region field is not set on lower levels than the library, it should behave as you want/describe.