search

lyarenei / jellyfin-plugin-listenbrainz

ListenBrainz plugin for Jellyfin.
MIT License
78 stars 3 forks source link

doesn't appear to work with music videos #57

Open UltimateRiff opened 11 months ago

UltimateRiff commented 11 months ago

I don't know if it's a matter of Jellyfin handling Music and Music Videos differently, but even after allowing my Music Video library for listen submission, it doesn't seem to do anything, neither a Now Playing status or a completed listen

image

lyarenei commented 11 months ago

When processing a played item, the plugin explicitly checks if the item is an audio item. Tbh it did not even occur to me to support music videos as that's something I have never used.

Allowing music videos should be fairly easy, although I think the listen submissions will be plain (only text, no metadata).

Implementation note: related to #58 - favorite sync will fail, because fallback using MSIDs is not implemented and there would be no MBID available in this case.

UltimateRiff commented 11 months ago

I did add a feature request in the Jellyfin feature requests hub, for what it's worth, so hopefully someday the second part will work~ https://features.jellyfin.org/posts/2484/add-musicbrainz-as-a-music-video-metadata-provider

lyarenei commented 11 months ago

@UltimateRiff Unless I'm mistaken, adding support for music videos to the MusicBrainz plugin means implementing a metadata provider for a Recording MBID. Which would also coincidentally address this issue.