lyarenei / jellyfin-plugin-listenbrainz

ListenBrainz plugin for Jellyfin.
MIT License
65 stars 2 forks source link

Issues with large playlists #60

Closed tuxfoo closed 5 months ago

tuxfoo commented 6 months ago

Hi,

I have very long playlists with 2000+ songs.

It still submits the listen to listenbrainz after the track has finished.

But the "listening now" function does not work.

I get this error regardless of if the plugin is enabled or not:

[2023-12-09 18:03:21.769 +13:00] [ERR] [194] Jellyfin.Server.Middleware.ExceptionMiddleware: Error processing request. URL "POST" "/Sessions/Playing".
Error: SQLitePCL.pretty.SQLiteException: Expression tree is too large (maximum depth 1000)

Obviously I could change the SQLite settings to accept this (which I wont do because that is a bad idea).

I noticed that I could still query the api at /Sessions and still displays the the correct NowPlayingItem

lyarenei commented 6 months ago

Hi, maybe that error prevents the server from emitting the playback start event? If the event is emitted, then the plugin should react on it - you should see Picking up playback start event for item ... in the log when that happens.

If the events are picked up by the plugin, then there must be an error somewhere in the logs that prevented sending a now_playing listen. Otherwise there are no playback start events emitted, so the plugin doesn't know something has started playing.

Obviously I could change the SQLite settings to accept this (which I wont do because that is a bad idea).

While you are right, you can do so temporarily to see if it's the root cause or not - increasing the limit will either fix the issue or at least will eliminate this variable.

lyarenei commented 5 months ago

Closing due to inactivity.