lybros / appa

GUI for TheiaSfM multiview geometry and structure from motion library.
6 stars 3 forks source link

code style #28

Closed Drapegnik closed 7 years ago

Drapegnik commented 7 years ago

@UladBohdan, i think we should find some code style, to follow it.

Now we have:

Category 'build/header_guard' errors found: 2
Category 'build/include_order' errors found: 17
Category 'build/include_subdir' errors found: 20
Category 'build/include_what_you_use' errors found: 7
Category 'legal/copyright' errors found: 1
Category 'readability/alt_tokens' errors found: 1
Category 'readability/casting' errors found: 3
Category 'readability/inheritance' errors found: 2
Category 'runtime/explicit' errors found: 3
Category 'runtime/indentation_namespace' errors found: 2
Category 'runtime/references' errors found: 4
Category 'whitespace/blank_line' errors found: 4
Category 'whitespace/comments' errors found: 1
Category 'whitespace/indent' errors found: 4
Category 'whitespace/line_length' errors found: 2
Category 'whitespace/parens' errors found: 8
Total errors found: 81
UladBohdan commented 7 years ago

the script works well for linux as for now, it returns the same bunch of errors.

and why discussing that here and not in PR ?

Drapegnik commented 7 years ago
UladBohdan commented 7 years ago

have you looked through all script options and sure we don't need to specify anything else?

Drapegnik commented 7 years ago

and we can improve lint settings for us, and fix script

no, we should do this during fix this issue