search

lybros / appa

GUI for TheiaSfM multiview geometry and structure from motion library.
6 stars 3 forks source link

add QtAwesome, fix #8 #9

Closed Drapegnik closed 7 years ago

Drapegnik commented 7 years ago

@UladBohdan can you watch?

UladBohdan commented 7 years ago

@Drapegnik

  1. is it either long path + submodules or simple copying a directory, but with a shorter path? (as no samples/readmes will be copied). The last contribution into QtAwesome was 3 moths ago - do we really need a submodule?
  2. i would "target_link_libraries" with QtAwesome in ui/CMakeLists.txt. The same for add_subdirectory(libs/QtAwesome/QtAwesome)
  3. what if we do not change MainWindow constructor signature, put all QtAwesome initialization into a MainWindow::SomeMethod and than call it from main() after the MainWindow object is created?
UladBohdan commented 7 years ago

@Drapegnik "libs" or "3rdparty" ?