lycantropos / hypothesis_sqlalchemy

hypothesis strategies for generating SQLAlchemy objects
MIT License
28 stars 8 forks source link

Updated to work with latest hypothesis >= 4.53.2 #26

Closed ptallada closed 4 years ago

ptallada commented 4 years ago

Hi,

When using latest versions of hypothesis, the import fails with:

>>> from hypothesis_sqlalchemy import tabular Traceback (most recent call last): File "", line 1, in File "/tmp/hypothesis_sqlalchemy/hypothesissqlalchemy/tabular/__init_\.py", line 1, in from . import records File "/tmp/hypothesis_sqlalchemy/hypothesis_sqlalchemy/tabular/records.py", line 3, in from hypothesis.searchstrategy.collections import TupleStrategy ModuleNotFoundError: No module named 'hypothesis.searchstrategy'

codecov[bot] commented 4 years ago

Codecov Report

Merging #26 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #26   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          12     12           
  Lines         229    228    -1     
=====================================
- Hits          229    228    -1
Impacted Files Coverage Δ
hypothesis_sqlalchemy/tabular/records.py 100% <ø> (ø) :arrow_up:
hypothesis_sqlalchemy/hints.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa12703...254689c. Read the comment docs.

lycantropos commented 4 years ago

can you also update .azure-pipelines.yml file and replace vmImage values for jobs to

jobs:
  - job: 'Windows'
    pool:
      vmImage: 'windows-latest'

...

  - job: 'MacOS'
    pool:
      vmImage: 'macOS-latest'

? it will enable tests on MacOS machines (and will help to avoid this kind of problems in the future I hope).

ptallada commented 4 years ago

Updated azure pipelines

lycantropos commented 4 years ago

also for Travis CI tests to run using PyPy we probably should change .travis.yml from

sudo: false
distro: trusty

to

dist: xenial

(you can see how CI providers changed in 5 months)

ptallada commented 4 years ago

Are you looking for a new maintainer? :-P

Also, I have not much idea about travis...

lycantropos commented 4 years ago

Are you looking for a new maintainer? :-P

Also, I have not much idea about travis...

You are already a maintainer (or at least contributor) :-)

and I can't accept PR without green tests

ptallada commented 4 years ago

and I can't accept PR without green tests

I understand :)

lycantropos commented 4 years ago

Thanks for your PR, now I'll bump and release a new version.

ptallada commented 4 years ago

Great!

Thanks :)