lycheeverse / lychee-action

Github action to check for broken links in Markdown, HTML, and text files using lychee, a fast link checker written in Rust.
https://lychee.cli.rs
Apache License 2.0
318 stars 44 forks source link

Add `*.rst` glob pattern to defaults #197

Closed kdeldycke closed 1 year ago

kdeldycke commented 1 year ago

Lychee is advertising its capability of checking reStructuredText files, so I guess it is a good idea to add these files to the default glob pattern.

mre commented 1 year ago

Hey Kevin, great idea!

Code looks good. Could you also add an example fixtures/TEST.rst file with some links and add a test like this? (Ideally, we'd want to check the links it found in the tests as well, but at the moment we only test the lychee invocation.)

kdeldycke commented 1 year ago

Could you also add an example fixtures/TEST.rst file with some links and add a test like this? (Ideally, we'd want to check the links it found in the tests as well, but at the moment we only test the lychee invocation.)

Done!

Is that good to you? Can you approve the workflow run on that PR so we can check everything's fine?

mre commented 1 year ago

You got it.

kdeldycke commented 1 year ago

Thanks @mre for the fast merge and feedback!