lycheeverse / lychee-action

Github action to check for broken links in Markdown, HTML, and text files using lychee, a fast link checker written in Rust.
https://lychee.cli.rs
Apache License 2.0
292 stars 39 forks source link

feat: support using nightly version #203

Closed kemingy closed 2 months ago

kemingy commented 10 months ago

As we accomplished in https://github.com/lycheeverse/lychee/pull/1212. We're now able to use the nightly release. However, I found that this action will add a v prefix to the lycheeVersion.

I'm not sure which way you prefer:

What do you think? I'm glad to create a PR.

mre commented 10 months ago

I would say the first option is the cleanest, as this is clearly a paper cut, which can trip people up.

In order to avoid breaking changes, let's prepare a PR which removes the v prefix and release a version 2 of the action along with https://github.com/lycheeverse/lychee-action/pull/86 and https://github.com/lycheeverse/lychee-action/pull/85. Sounds good?

kemingy commented 10 months ago

SGTM. Let me create PR for this.

tooomm commented 8 months ago

As it fits the idea... Did you also consider to allow lycheeVersion: latest to grab not the nightly, but the latest full release.

Currently, this repo needs a manual push to match a new release on the main repo, e.g. https://github.com/lycheeverse/lychee-action/commit/5d778f12698c76948e17c76729f3222acf92594a.

mre commented 7 months ago

@kemingy, do you have any thoughts on this? I'm not sure what to do here. I wouldn't be against adding such an option, but it might be some additional work.

kemingy commented 7 months ago

I think it requires additional logic to get the latest release version in the action.

One possible cmd is:

gh release list --repo lycheeverse/lychee --exclude-drafts --exclude-pre-releases --limit 1 | awk '{print $4}'
mre commented 7 months ago

Thanks for the info. I wouldn't mind adding support for it if someone is willing to create a pull request for it. If it's a lot of work, then it's out of scope for now.