search

lycheeverse / lychee-action

Github action to check for broken links in Markdown, HTML, and text files using lychee, a fast link checker written in Rust.
https://lychee.cli.rs
Apache License 2.0
292 stars 39 forks source link

The `set-output` command is deprecated #213

Closed tannerjones4075 closed 6 months ago

tannerjones4075 commented 8 months ago

Running the lycheeverse/lychee-action@v1.0.8 and get the following output: image

tannerjones4075 commented 8 months ago

https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I would be willing to contribute if I could get some guidance.

mre commented 8 months ago

Yes, that would be amazing.

The example in the link explains the transition really well. https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/#examples

You would need to replace all occurrences of set-output with the new syntax. A search for all occurrences should be enough to find the spots.

tooomm commented 6 months ago

https://github.com/lycheeverse/lychee-action/pull/167 replaced set-output with $GITHUB_ENV instead $GITHUB_OUTPUT over a year ago.

You are using a very old version (v1.0.8) @tannerjones4075

mre commented 6 months ago

Indeed. Sorry, I overlooked that. In the back of my mind I remembered that we did something along those lines, but I thought that maybe we forgot a spot. 😅 Guess we can close this.