search

lycheeverse / lychee-action

Github action to check for broken links in Markdown, HTML, and text files using lychee, a fast link checker written in Rust.
https://lychee.cli.rs
Apache License 2.0
292 stars 39 forks source link

Specifying lycheeVersion as "nightly" broken #232

Open osslate opened 1 week ago

osslate commented 1 week ago

As the GitHub Action prepends "v" to the lycheeVersion (so it becomes vnightly instead of nightly) when grabbing the binary from GitHub, trying to use the nightly version with this GitHub Action is broken.

mre commented 1 week ago

Oh well.

Wonder how we can fix it.

osslate commented 1 week ago

To avoid breaking compatibility with people already using the Action, a solution might be introducing a useNightly option that overrides lycheeVersion.

mre commented 1 week ago

We could introduce a breaking change with a new version but yeah, it's not ideal. Alternatively, we could check if version is nightly and avoid prepending the v.