search

lycheeverse / lychee-action

Github action to check for broken links in Markdown, HTML, and text files using lychee, a fast link checker written in Rust.
https://lychee.cli.rs
Apache License 2.0
323 stars 48 forks source link

Have `lycheeVersion: latest` to use the current lychee release #256

Open tooomm opened 3 weeks ago

tooomm commented 3 weeks ago

As discussed earlier in a related ticket to https://github.com/lycheeverse/lychee/pull/1212: https://github.com/lycheeverse/lychee-action/issues/203

See comments following https://github.com/lycheeverse/lychee-action/issues/203#issuecomment-1784083059, including a proposed logic by @kemingy.

This could be a good standard setting for the action in general and can get rid of constant manual version bumps to stay en par with the main tool (e.g. https://github.com/lycheeverse/lychee-action/commit/ebd95ebde89b46eaf3567432efb0b52bad2187d7).

mre commented 3 weeks ago

Wouldn't this update the lychee version even for users who've pinned the lychee-action? This could potentially introduce breaking changes unexpectedly.

I'm not entirely sure how GitHub Actions handle this interaction between action versions and tool versions.

mre commented 12 hours ago

@tooomm, any thoughts?