test: fail when interpreting md footnote as link

lycheeverse / lychee

⚡ Fast, async, stream-based link checker written in Rust. Finds broken URLs and mail addresses inside Markdown, HTML, reStructuredText, websites and more!

https://lychee.cli.rs

Apache License 2.0

2.22k stars 134 forks source link

test: fail when interpreting md footnote as link #1479

Closed mre closed 3 months ago

mre commented 3 months ago

WIP for https://github.com/lycheeverse/lychee/issues/1409.

Accidentally closed #1410 by rebasing on top of master, then pushing mid-rebase and don't have permissions to push there. 😅 So reopening here.

@jan-ferdinand fyi

The underlying issue is still not fixed. Just rebased. @thomas-zahner let me know if you're still looking into this one.

mre commented 3 months ago

@thomas-zahner, what do you think? I followed your advice and parsed the plaintext if link_type isn't LinkedType::Inline. Turned out nicely. Did I miss anything?

mre commented 3 months ago

I went ahead and merged this. The tests pass and the changes just extended the existing logic. If we find a bug with it, we can easily fix it in-place.

thomas-zahner commented 3 months ago

Ah that looks good, thanks for the implementation :+1: