Closed dependabot[bot] closed 3 months ago
@thomas-zahner @HU90m, what do you think about this one?
Used a RefCell
to get around the limitations of a recent change of the html5ever API.
https://github.com/servo/html5ever/pull/548
It causes a runtime overhead, but I guess it should be fine. Can't see a better way to update the link list if the trait method doesn't take &mut self
.
Changing
fn process_token(&self, token: Token, _line_number: u64) -> TokenSinkResult<()> { ... }
to
fn process_token(&self, token: Token, _line_number: u64) -> TokenSinkResult<Vec<RawUri>> { ... }
wouldn't work because html5ever
calls process_token
internally and we couldn't access the extracted links (Vec<RawUri>
) anywhere.
I would go ahead and merge this to not make it a blocker for updating the dependencies. The failing test is unrelated and the Docker build also needs to be tackled at some point. @thomas-zahner sounds good?
Yes that sounds good, I don't see any problem with it.
Of course it would be nice if no RefCell
was required but I don't see any other way
I don't fully understand their design decision to do that change but they have also updated their tests in the PR by wrapping their self
values in Cell
or RefCell
. So I guess that's the way to do it
Bumps the dependencies group with 6 updates:
4.5.13
4.5.15
1.0.204
1.0.206
1.0.122
1.0.124
2.0.15
2.0.16
3.11.0
3.12.0
0.27.0
0.28.0
Updates
clap
from 4.5.13 to 4.5.15Release notes
Sourced from clap's releases.
Changelog
Sourced from clap's changelog.
Commits
4094435
chore: Release36114c3
docs: Update changelog918cfed
Merge pull request #5610 from Mixu78/powershell_hyphensc55f642
Merge pull request #5648 from epage/cli219a191
fix(complete): Improve help output734cac7
feat(complete): Make '--register' optionalfa4ccec
feat(complete): Make '--shell' optionalefdcad1
Merge pull request #5647 from epage/infere65e463
docs(complete): Have dynamic Shell match static Shell8a1f9b3
Merge pull request #5646 from epage/powershellUpdates
serde
from 1.0.204 to 1.0.206Release notes
Sourced from serde's releases.
Commits
85c73ef
Release 1.0.2065ba1796
Resolve doc_markdown pedantic lint on regression test functione52b7b3
Touch up PR 256784c7419
Merge pull request #2794 from dtolnay/neverread536221b
Temporarily ignore collection_is_never_read on FlattenSkipDeserializingfc55ac7
Merge pull request #2567 from Mingun/fix-25652afe5b4
Add regression test for issue #2792b4ec259
Correctly process flatten fields in enum variantsc3ac7b6
Add regression test for issue #190424614e4
Add regression test for issue #2565Updates
serde_json
from 1.0.122 to 1.0.124Release notes
Sourced from serde_json's releases.
Commits
cf771a0
Release 1.0.1248b314a7
Merge pull request #1173 from iex-rs/fix-big-endian8eba786
Fix skip_to_escape on BE architectures2cab07e
Release 1.0.123346189a
Fix needless_borrow clippy lint in new control character test859ead8
Merge pull request #1161 from iex-rs/vectorized-string-parsinge43da5e
Immediately bail-out on empty strings8389d8a
Don't run the slow algorithm from the beginning1f0dcf7
Allow clippy::items_after_statementsa95d6df
Big endian supportUpdates
assert_cmd
from 2.0.15 to 2.0.16Changelog
Sourced from assert_cmd's changelog.
Commits
bf1025e
chore: Release assert_cmd version 2.0.1650e8293
docs: Update changelog6539f0a
Merge pull request #213 from mcky/feat-add-command-gettersb037f96
feat: Add getters to mirror those available on std::process::Command4d3dbd3
chore(deps): Update Rust crate escargot to v0.5.12936e453
Merge pull request #210 from epage/min26a368c
chore: Clean up minimal deps hack3229492
chore(deps): Update Rust Stable to v1.807c63917
Merge pull request #208 from epage/template3dc2b41
fix: Workaround bad minimal-versionsUpdates
tempfile
from 3.11.0 to 3.12.0Changelog
Sourced from tempfile's changelog.
Commits
Updates
html5ever
from 0.27.0 to 0.28.0Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show