lycheeverse / lychee

⚡ Fast, async, stream-based link checker written in Rust. Finds broken URLs and mail addresses inside Markdown, HTML, reStructuredText, websites and more!
https://lychee.cli.rs
Apache License 2.0
2.22k stars 134 forks source link

bug in searching for alternatives #1501

Closed phanirithvij closed 1 month ago

phanirithvij commented 2 months ago

This has been running for 10mins

lychee -E  --cache --scheme http --scheme https --include-verbatim --timeout 5 --suggest
  1659/1659 ━━━━━━━━━━━━━━━━━━━━ Finished extracting links
⠂ 14/15 ━━━━━━━━━━━━━━━━━━ ━ Searching for alternatives   

Can the --timeout flag be used for archive checking step as well?

mre commented 2 months ago

Great idea. @thomas-zahner fyi

In general, archive.org is super slow quite often at least for me. We could support alternatives, but I'm not aware of any.

thomas-zahner commented 2 months ago

Yes, I totally agree that the timeout value should be respected by the archive lookup step. @mre there aren't many alternatives. archive.today is maybe the only one. There is also the Time Travel Service which sounds interesting.

mre commented 2 months ago

I'm all for it. Guess we could pass the timeout already. Anyone up for fixing it with a PR?

mre commented 1 month ago

Fixed by @thomas-zahner and will be released with the next version 0.6.2.