fix: Bring back error output for links

lycheeverse / lychee

⚡ Fast, async, stream-based link checker written in Rust. Finds broken URLs and mail addresses inside Markdown, HTML, reStructuredText, websites and more!

https://lychee.cli.rs

Apache License 2.0

2.23k stars 136 forks source link

fix: Bring back error output for links #1521

Closed mre closed 3 weeks ago

mre commented 1 month ago

Superseded by #1553

With the last lychee release, we simplified the status output for links.

While this reduced the visual noise, it also accidentally caused the source of errors to not be printed anymore. This change brings back the additional error information as part of the final report output. Furthermore, it shows the error information in the progress output if verbose mode is activated.

Fixes #1487

mre commented 1 month ago

@dmathieu, do you have an idea why the test fails..

dmathieu commented 1 month ago

do you have an idea why the test fails..

It's a bit weird. I'm not getting a failure locally. As if sometimes, a 200 is returned (giving the error we see), and sometimes a 204.

mre commented 3 weeks ago

See #1553 for a cleaned up version of this.