lydavid / MusicSearch

An Android app for browsing songs, artists, and anything related to them
https://lydavid.github.io/MusicSearch/
Apache License 2.0
45 stars 0 forks source link

module graph assert to make sure feature modules don't depend on other feature modules #546

Open lydavid opened 1 year ago

lydavid commented 1 year ago

https://github.com/jraska/modules-graph-assert

lydavid commented 1 year ago

if feature modules contain more than just ui, is there anything wrong with them depending on one another?

lydavid commented 8 months ago

With circuit, a feature that may navigate to another feature just needs to sink an event to navigate to that screen. Even before circuit, we had a Destination enum for that.

Common ui shouldn't be in feature modules

lydavid commented 3 months ago

Other projects would extract the common ui out to a common module, then have each of the feature module depend on that

lydavid commented 3 weeks ago

Another approach is to have feature-impl and feature-api, where feature modules may depend on the api for other modules but not its impl.