search

lydell / LinkHints

A browser extension that lets you click with your keyboard.
https://lydell.github.io/LinkHints
MIT License
155 stars 8 forks source link

Filter by text unclear in tutorial #46

Closed nickvisut closed 3 months ago

nickvisut commented 2 years ago

Steps to reproduce

  1. Go to: https://lydell.github.io/LinkHints/tutorial.html#step-4
  2. Type: 2001
  3. Note that nothing is highlighted
  4. Press: enter
  5. I would expect "2001" to be highlighted and enter to open the toggle

Screen shot

link-hints-filter-by-text

Description

The filter by text feature, as described, seems to allow the user to input characters to partially match link text. Upon trying this in the tutorial by typing "2001", nothing appears to happen. I would expect "2001" to be highlighted.

Debug info

Debug info ```json { "version": "1.2.0", "browser": "chrome", "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.110 Safari/537.36", "platformInfo": { "arch": "arm64", "nacl_arch": "arm", "os": "mac" }, "storage.sync": {}, "storage.local": { "tutorialShown": true }, "language": "en-US", "layout": { "KeyE": "e", "KeyD": "d", "Minus": "-", "KeyH": "h", "KeyZ": "z", "Equal": "=", "KeyN": "n", "KeyP": "p", "BracketRight": "]", "BracketLeft": "[", "Digit8": "8", "Digit9": "9", "KeyS": "s", "Semicolon": ";", "Digit5": "5", "KeyQ": "q", "KeyO": "o", "Period": ".", "Digit6": "6", "KeyV": "v", "Digit3": "3", "KeyL": "l", "Backquote": "`", "KeyG": "g", "KeyJ": "j", "KeyT": "t", "Quote": "'", "KeyY": "y", "IntlBackslash": "§", "KeyR": "r", "Backslash": "\\", "KeyU": "u", "KeyK": "k", "Slash": "/", "KeyF": "f", "KeyI": "i", "KeyX": "x", "KeyA": "a", "Digit2": "2", "Digit7": "7", "KeyM": "m", "Digit4": "4", "KeyW": "w", "Digit1": "1", "Digit0": "0", "KeyB": "b", "KeyC": "c", "Comma": "," } } ```
lydell commented 2 years ago

Hi! What are the “two zero zero one” and “enter” things in the bottom right?

nickvisut commented 2 years ago

Hello! That is talonvoice.com which I use due to RSI.

I’ve also tested with keyboard, however.

On Sat, Jan 1, 2022 at 12:24 AM Simon Lydell @.***> wrote:

Hi! What is the “two zero zero one” and “enter” things in the bottom right?

— Reply to this email directly, view it on GitHub https://github.com/lydell/LinkHints/issues/46#issuecomment-1003525867, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVRHSHBR73YOCNTXHKOUJDUT223JANCNFSM5LBU7QYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

lydell commented 2 years ago

Do you use Vimium (or some other Vim-for-browser plugin) by any chance? It “steals” digit presses for its count feature.

If not:

nickvisut commented 2 years ago

Thanks for the questions/tips. I was using vimium in Chrome before, but I disabled it because I was looking for an extension that had persistent hints. I double checked that it wasn’t running and also tested in a profile with minimal extensions; also ran it in FF).

I tried letters with shift and no luck either.

Upon your suggestion, I disabled or uninstalled all apps I could think of that monitor keyboard input and that didn’t seem to help either. FWIW I’m on an M1 Mac on MacOS Monterey.

On Sat, Jan 1, 2022 at 7:51 AM Simon Lydell @.***> wrote:

Do you use Vimium (or some other Vim-for-browser plugin) by any chance? It “steals” digit presses for its count feature.

If not:

  • Can you filter by other chars than digits, such as letters? (Hold shift.)
  • Do you use any other keyboard related extensions or programs?

— Reply to this email directly, view it on GitHub https://github.com/lydell/LinkHints/issues/46#issuecomment-1003576257, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVRHSCUV7SYSTPYVT3YXRLUT4PHFANCNFSM5LBU7QYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

lydell commented 2 years ago

Thanks for your investigation!

I use a mac myself, but not an M1. Maybe things don’t work on M1, I don’t know. I’m out of ideas.

I was looking for an extension that had persistent hints

Note that Link Hints does not have persistent hints either (if I understand what you mean by “persistent”) – Link Hints’ hints are very similar to Vimium.

lydell commented 2 years ago

Ok, one more idea. You say “Filter by text not working in tutorial”. Is it only in the tutorial that it doesn’t work?

nickvisut commented 2 years ago

It appears to not work anywhere, unfortunately. Do you think it's the M1?

As for Link Hints not having persistent hints, is that something you had consider adding? Pretty helpful in cases where someone will be using link hints almost exclusively to navigate. Saves more keypresses than you might imagine. It is partially persistent due to the "Click many" and "Open many tabs", which is one reason I'm using it over Vimium.

On Sat, Jan 1, 2022 at 11:24 PM Simon Lydell @.***> wrote:

Ok, one more idea. You say “Filter by text not working in tutorial”. Is it only in the tutorial that it doesn’t work?

— Reply to this email directly, view it on GitHub https://github.com/lydell/LinkHints/issues/46#issuecomment-1003674908, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAVRHSEU3GO7LOHNOGGTKALUT74SZANCNFSM5LBU7QYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

lydell commented 2 years ago

Do you think it's the M1?

It could be. But I have no idea what’s going on on your computer, really. It’s so weird that it simply does not work at all, while shortcuts and typing hints work. Sounds impossible! 🤯

As for Link Hints not having persistent hints, is that something you had consider adding?

See https://github.com/lydell/LinkHints/issues/57#issuecomment-1188693114

lydell commented 2 years ago

I was finally able to test on an M1 Mac today! Filter by text works though, including in the tutorial.

I noticed one step is missing in your steps to reproduce though (never noticed before):

  1. Go to: https://lydell.github.io/LinkHints/tutorial.html#step-4
  2. Press ^J – this was missing!
  3. Type: 2001
  4. Note that nothing is highlighted
  5. Press: enter
  6. I would expect "2001" to be highlighted and enter to open the toggle

So maybe the tutorial has simply been unclear this whole time?