nus-pe-bot
commented
3 years ago Team's Response
The userflow is stated in our addBooking UG. Before the user wants to make a new booking, he is expected to run findPerson command first to see if the guest exists in the personBook already. If the person exists, then the user will not create a new guest profile. Hence this is a rare situation. Moreover, we have the ID that can be used to differentiate between the two Person in the worse case, which is uniquely assigned to each Person.
Items for the Tester to Verify
:question: Issue type
Team chose [type.FunctionalityBug]
Originally [type.FeatureFlaw]
- [x] I disagree
Reason for disagreement: I think the bug type shouldn't be a Functionality Bug as I think there isn't anything wrong with the behavior of the feature but it should be a Feature Flaw.
It is true that users can follow the step stated in the UG, but what if they doesn't follow it. Furthermore, you can't assume that every users will not add the same guest profile even after using the find command to find it. I do agree that the ID serve the purpose of differentiating the same person but if they represent the same person, we shouldn't even be differentiating them in the first place.
Besides that, it is mentioned in the user stories that the customer profiles are used to keep track of their past bookings. If we have 2 instances of the same person in the app, which one should we check for their past bookings? Do both of them store the correct data or only one is correct? If both is correct, do we still need to look through both of them to check for their past bookings? These are some of the questions that I have been thinking about. From this, I think the feature becomes less useful to the users and there is some missing functionality here which is the uniqueness of the person list. That's why I think this is a Feature Flaw.
:question: Issue severity
Team chose [severity.Low]
Originally [severity.Medium]
- [ ] I disagree
Reason for disagreement: [replace this with your explanation]
Duplicate person with the same value in each field can be added, which doesn't make sense for me for a hotel booking app.