lyft / Lyft-iOS-sdk

Public Lyft SDK for iOS
Other
43 stars 27 forks source link

iOS SDK broken for all calls in Canada (as well as non-US regions) #21

Open marchy opened 6 years ago

marchy commented 6 years ago

The Lyft API is giving an invalid error when invoked from the iOS SDK on any of the ride type, estimates and ETA routes. Instead of giving back results, it errors saying there is no service in the area (Toronto, Canada).

EXAMPLE: GET request to https://api.lyft.com/v1/eta?lat=43.6479328&lng=-79.3778371

ERROR: no_service_in_area The requested location is not inside a Lyft service area

This is what the iOS SDK currently sends (BROKEN): enter image description here

When invoking the API manually, the error doesn't happen if the user agent which the SDK sends out is omitted ('User-Agent' value of 'lyft-mobile-sdk:ios::1.0.6')

Removing 'User-Agent' works: enter image description here

Confirmed that forking the iOS SDK and removing User-Agent removes this error (commit here: https://github.com/marchy/Lyft-iOS-sdk/commit/c23811f890e4881ef0e6789b6392b1a38db1334d) – thus the bug is confirmed to be on the API front.

This is a critical break and affects all calls made from the iOS SDK (at least up here in Canada – and perhaps other non-US regions).

marchy commented 6 years ago

Any update on this?