lyft / awspricing

Python library for AWS pricing.
Other
208 stars 53 forks source link

Bump mypy version and fix new errors #20

Closed patrickvalenzuela closed 6 years ago

patrickvalenzuela commented 6 years ago

These errors exist on master ahead of this PR:

awspricing/offers.py:227: error: Argument 1 to "_validate_reserved_price_args" of "EC2Offer" has incompatible type "Optional[str]"; expected "str" awspricing/offers.py:227: error: Argument 3 to "_validate_reserved_price_args" of "EC2Offer" has incompatible type "Optional[str]"; expected "str" awspricing/offers.py:243: error: Argument 2 to "_get_reserved_offer_term" of "EC2Offer" has incompatible type "List[Optional[str]]"; expected "List[str]" awspricing/offers.py:306: error: Argument 1 to "_validate_reserved_price_args" of "EC2Offer" has incompatible type "Optional[str]"; expected "str" awspricing/offers.py:306: error: Argument 3 to "_validate_reserved_price_args" of "EC2Offer" has incompatible type "Optional[str]"; expected "str" awspricing/offers.py:322: error: Argument 2 to "_get_reserved_offer_term" of "EC2Offer" has incompatible type "List[Optional[str]]"; expected "List[str]" awspricing/offers.py:409: error: Argument 1 to "hash_attributes" of "AWSOffer" has incompatible type "*List[Optional[str]]"; expected "str" awspricing/offers.py:451: error: Argument 1 to "_validate_reserved_price_args" of "RDSOffer" has incompatible type "Optional[str]"; expected "str" awspricing/offers.py:451: error: Argument 3 to "_validate_reserved_price_args" of "RDSOffer" has incompatible type "Optional[str]"; expected "str" awspricing/offers.py:467: error: Argument 2 to "_get_reserved_offer_term" of "RDSOffer" has incompatible type "List[Optional[str]]"; expected "List[str]" awspricing/offers.py:530: error: Argument 1 to "_validate_reserved_price_args" of "RDSOffer" has incompatible type "Optional[str]"; expected "str" awspricing/offers.py:530: error: Argument 3 to "_validate_reserved_price_args" of "RDSOffer" has incompatible type "Optional[str]"; expected "str" awspricing/offers.py:546: error: Argument 2 to "_get_reserved_offer_term" of "RDSOffer" has incompatible type "List[Optional[str]]"; expected "List[str]"