core: allow confirmation message to be configured

lyft / clutch

Extensible platform for infrastructure management

https://clutch.sh

Apache License 2.0

1.7k stars 119 forks source link

core: allow confirmation message to be configured #1150

Open micnncim opened 3 years ago

micnncim commented 3 years ago

I'd like to configure the confirmation message with an arbitrary message inConfirmation component. Currently, any message has the "Requested" suffix, but it'd make more sense to use another word in some cases and there wouldn't be no reason to restrict it.

https://github.com/lyft/clutch/blob/7dd5280f3816811cb562dea8de55714c2fe4cf50/frontend/packages/core/src/confirmation.tsx#L45

Complexity [S/M/L]: S

Wireframes, Mockups, or Screenshots (if applicable)

dschaller commented 3 years ago

👍 This seems reasonable. By default we append requested to denote the action is scheduled but not confirmed but there is no reason to force this.

micnncim commented 3 years ago

Thanks!

denote the action is scheduled

Yeah, I understand the intention 👍 Could I send a PR for this if you don't mind?

dschaller commented 3 years ago

of course! :)