Closed lucechal14 closed 1 week ago
LGTM, the only thing that feels odd is using the workflow's display name as key since it could be anything, didn't see an obvious alternative though 😅
Kind of an edge case for the header alert, a long link text can displace the description message. Also, long description messages don't take the available height and overflow at 2 lines. I don't think the component should hold huge chunks of text like that, but some handling could come handy just in case.
Kind of an edge case for the header alert, a long link text can displace the description message. Also, long description messages don't take the available height and overflow at 2 lines. I don't think the component should hold huge chunks of text like that, but some handling could come handy just in case.
Yes the description has a set height and the it will overflow in case the description is too big, for the link the idea is that it is a small text, overall the idea of the header banner is just small text.
Kind of an edge case for the header alert, a long link text can displace the description message. Also, long description messages don't take the available height and overflow at 2 lines. I don't think the component should hold huge chunks of text like that, but some handling could come handy just in case.
Yes the description has a set height and the it will overflow in case the description is too big, for the link the idea is that it is a small text, overall the idea of the header banner is just small text.
Good catch @jecr. @lucechal14 let's make sure it doesn't break free if it's too long. The idea is for it to not be very large but if it is I'd rather it be hidden or truncated versus breaking outside of the header. Can likely just overflow: scroll
it and move the maxHeight to the alert itself.
Kind of an edge case for the header alert, a long link text can displace the description message. Also, long description messages don't take the available height and overflow at 2 lines. I don't think the component should hold huge chunks of text like that, but some handling could come handy just in case.
Yes the description has a set height and the it will overflow in case the description is too big, for the link the idea is that it is a small text, overall the idea of the header banner is just small text.
Good catch @jecr. @lucechal14 let's make sure it doesn't break free if it's too long. The idea is for it to not be very large but if it is I'd rather it be hidden or truncated versus breaking outside of the header. Can likely just
overflow: scroll
it and move the maxHeight to the alert itself.
@jdslaugh @jecr done, here is how it looks like
Description
Support for Notifications across the app. We have 3 types of notifications:
Examples
Header and Per Workflow notification
Header and Multi Workflow notification
Testing
You can use an object similar to this to test:
const banners = { header: { message: "header message", linkText: "link", link: "linkhere", severity: "info", }, perWorkflow: { workflowName1: { title: "per workflow title for test 2", message: "per workflow message for test 2", linkText: "link", link: "linkhere", severity: "info", }, workflowName2: { title: "per workflow title for test 3", message: "per workflow message for test 3", linkText: "link", link: "linkhere", severity: "info", }, }, multiWorkflow: { title: "multi workflow title", message: "multi workflow message", workflows: ["workflowName1", "workflowName3"], severity: "info", linkText: "link", link: "linkhere", }, };
Send this const as banners in the appConfiguration prop of your ClutchApp