search

lyft / clutch

Extensible platform for infrastructure management
https://clutch.sh
Apache License 2.0
1.7k stars 119 forks source link

authn: support GitHub login #31

Open danielhochman opened 4 years ago

danielhochman commented 4 years ago

Description

The oauth2 flow is already implemented, will just need some tweaks to support GitHub as the current authn implementation is only set-up for OIDC flows (e.g. Okta).

InfluxDB's Chronograf backend has a great example of handling GitHub and other forms of login generically that should be adaptable to Clutch's components. https://github.com/influxdata/influxdb/blob/master/chronograf/oauth2/github.go

Complexity [S/M/L]: M

gramidt commented 4 years ago

@danielhochman - I would love to take a stab at implementing this! Also, great blog post announcement today btw!

danielhochman commented 4 years ago

@gramidt thanks so much for the kind words.

the team here is ready to provide contributor support wherever it's needed. keep the feedback coming as you onboard and we'll be sure to address it with additional docs if necessary.

the first step in implementing github auth will be adding a github object to the type oneof in the authn service config here: https://github.com/lyft/clutch/blob/6c516269614e0300a230d3b5f88b4e14e3f1c058/api/config/service/authn/v1/authn.proto#L21-L23

gramidt commented 4 years ago

Awesome! Thank you for pointing me in the right direction to kick this feature off.